Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 股票图增强 #2579

Merged
merged 13 commits into from
May 24, 2021
Merged

feat: 股票图增强 #2579

merged 13 commits into from
May 24, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented May 23, 2021

Checklist

  • Geometry Style 支持上涨色、下跌色
  • Tooltip ✅ 代码重构 ✅ 轴 tooltip 指示器优化
  • Slider ✅ 缩略轴 slider

PR includes

  • feat(stock): 股票图支持配置上涨色&下跌色
  • feat(stock): 股票图支持缩略轴 slider
  • docs(stock): 添加股票图上涨色&下跌色配置的 demo 和文档
  • docs(tooltip): 完善 tooltip crosshairs 文档
  • refactor(stock): 增加 schema geometry adaptor & 重构股票图 tooltip(精简股票图 tooltip 配置,默认展示更优)
  • docs(stock): 增加若干股票图 demo

Screenshot

Before After

@visiky visiky changed the title feat: 股票图增强 wip: feat: 股票图增强 May 23, 2021
@coveralls
Copy link

coveralls commented May 23, 2021

Pull Request Test Coverage Report for Build 870796641

  • 29 of 29 (100.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 96.26%

Files with Coverage Reduction New Missed Lines %
src/plots/stock/adaptor.ts 2 92.06%
Totals Coverage Status
Change from base Build 869874785: 0.1%
Covered Lines: 5657
Relevant Lines: 5734

💛 - Coveralls

精简股票图 tooltip 配置,默认展示更优
增加若干 demo
@visiky visiky requested a review from jinhuiWong May 23, 2021 16:15
@visiky visiky requested a review from hustcc May 24, 2021 08:28
@visiky visiky changed the title wip: feat: 股票图增强 feat: 股票图增强 May 24, 2021
@hustcc hustcc self-requested a review May 24, 2021 11:03
@visiky visiky merged commit dea171a into master May 24, 2021
@visiky visiky deleted the enhance-stock branch May 24, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants