fix: 双轴图 theme 主题设置 #2451
Merged
fix: 双轴图 theme 主题设置 #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visiky
reviewed
Mar 24, 2021
visiky
reviewed
Mar 24, 2021
| * 双轴图中，部分组件是绘制在子 view 层（例如 axis，line），部分组件是绘制在 chart （例如 legend) | ||
| * 为 chart 和 子 view 均注册 theme，使其自行遵循 G2 theme geometry > view > chart 进行渲染。 | ||
| */ | ||
| commonTheme(deepAssign({}, params, { chart: findViewById(chart, LEFT_AXES_VIEW) })); |
There was a problem hiding this comment.
这个只要 g2 能正常创建出来，就会存在，反过来说，如果 view 没创建成功，整个 adaptor 里都得做层判断，感觉只在这个函数里判断意义不是很大：）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
Screenshot