Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 多图层图表正式开放 #2245

Merged
merged 13 commits into from
Jan 20, 2021
Merged

feat: 多图层图表正式开放 #2245

merged 13 commits into from
Jan 20, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 19, 2021 •
edited
Loading

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2021 •
edited
Loading

😭 Deploy PR Preview 6c71e11 failed. Build logs

🤖 By surge-preview

@visiky visiky changed the title wip: feat: 多图层图表正式开放 feat: 多图层图表正式开放 Jan 19, 2021
@visiky visiky force-pushed the feat-multi-view branch 2 times, most recently from 3bc343e to 285f7e2 Compare January 20, 2021 00:32
@coveralls
Copy link

coveralls commented Jan 20, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 498597951

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 96.811%
Files with Coverage Reduction New Missed Lines %
src/utils/transform/word-cloud.ts 1 97.75%
Totals Coverage Status
Change from base Build 498449672: -0.03%
Covered Lines: 4610
Relevant Lines: 4648
💛 - Coveralls

@visiky visiky force-pushed the feat-multi-view branch 2 times, most recently from feedbff to 7d59274 Compare January 20, 2021 03:00
lxfu1
lxfu1 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@lxfu1 lxfu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很好:^__^:

@lxfu1 lxfu1 merged commit 963399a into master Jan 20, 2021
@lxfu1 lxfu1 deleted the feat-multi-view branch January 20, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@lxfu1 lxfu1 lxfu1 approved these changes

@liuzhenying liuzhenying Awaiting requested review from liuzhenying

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@visiky @coveralls @hustcc @lxfu1