Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(liquid): 水波图支持动态 changedata #2198

Merged
merged 2 commits into from
Jan 10, 2021
Merged

feat(liquid): 水波图支持动态 changedata #2198

merged 2 commits into from
Jan 10, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 10, 2021

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ ✅

@visiky visiky requested a review from hustcc January 10, 2021 09:58
@visiky visiky added this to the change-data milestone Jan 10, 2021
@visiky visiky force-pushed the liquid-changedata branch from 50e2cfb to ff9085f Compare January 10, 2021 10:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2021 •
edited
Loading

😭 Deploy PR Preview 51e86ea failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 475428418

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 96.856%
Totals Coverage Status
Change from base Build 475341324: 0.007%
Covered Lines: 4552
Relevant Lines: 4590
💛 - Coveralls

@hustcc hustcc merged commit d1610f2 into master Jan 10, 2021
@hustcc hustcc deleted the liquid-changedata branch January 10, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
change-data
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc