fix: 修复散点图 tooltip 默认 fields 丢失 #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😭 Deploy PR Preview 68529bd failed. Build logs
🤖 By surge-preview |
Pull Request Test Coverage Report for Build 386412447
💛 - Coveralls |
|
求加对比前后的截图。参考 https://www.yuque.com/antv/g2plot/yux33f |
hustcc
reviewed
Nov 27, 2020
| if (tooltip && !tooltip.fields) { | ||
| tooltip = { | ||
| ...tooltip, | ||
| fields: [xField, yField, colorField, sizeField, shapeField], |
There was a problem hiding this comment.
应该就是给 tooltip fields 加默认值。
If tooltip
tooltip = { fields: [xxx], ...tooltip }
liuzhenying
approved these changes
Nov 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改前
修改后
