Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: funnel #1916

Merged
merged 7 commits into from
Nov 18, 2020
Merged

fix: funnel #1916

merged 7 commits into from
Nov 18, 2020

Conversation

liuzhenying
Copy link
Member

@liuzhenying liuzhenying commented Nov 14, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2020

😭 Deploy PR Preview 5e833dc failed. Build logs

🤖 By surge-preview

@lgtm-com
Copy link

lgtm-com bot commented Nov 14, 2020

This pull request introduces 1 alert when merging 9d565e6 into d9a9bc5 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 17, 2020

This pull request introduces 3 alerts when merging 5e41207 into d8aea09 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 17, 2020

This pull request introduces 2 alerts when merging 6f3f424 into d6255e0 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 17, 2020

This pull request introduces 1 alert when merging 81f64fc into 690c2af - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@coveralls
Copy link

coveralls commented Nov 17, 2020

Pull Request Test Coverage Report for Build 369299238

  • 45 of 46 (97.83%) changed or added relevant lines in 7 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 96.23%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plots/funnel/adaptor.ts 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
src/plots/waterfall/adaptor.ts 1 95.35%
src/plots/liquid/shapes/liquid.ts 3 92.71%
src/utils/statistic.ts 4 90.97%
Totals Coverage Status
Change from base Build 362749570: 0.2%
Covered Lines: 3904
Relevant Lines: 3953

💛 - Coveralls

@liuzhenying liuzhenying changed the title [WIP] fix: funnel fix: funnel Nov 17, 2020
@liuzhenying liuzhenying requested review from lxfu1 and hustcc and removed request for lxfu1 November 17, 2020 14:59
@hustcc hustcc self-requested a review November 18, 2020 01:22
@hustcc hustcc merged commit 9b7b189 into master Nov 18, 2020
@hustcc hustcc deleted the fix/funnel-tooltip branch November 18, 2020 01:46
@pr-triage pr-triage bot added the PR: merged label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants