Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multi-view plot #1843

Merged
merged 4 commits into from
Nov 4, 2020
Merged

feat: add multi-view plot #1843

merged 4 commits into from
Nov 4, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Nov 3, 2020

  • types 定义
  • coding
  • unit test
  • demo

主要用来实现如下类型的组合图表,充分暴露 G2 的能力(门槛高,是对图形语法的直接透出):

image image image image image

当然也可以用来绘制多折线,多面积(非拆分形式的)。

@hustcc hustcc requested review from lxfu1 and visiky November 3, 2020 06:55
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2020

😭 Deploy PR Preview 4978516 failed. Build logs

🤖 By surge-preview

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2020

This pull request introduces 3 alerts when merging d207469 into 0ad37a6 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@hustcc hustcc requested a review from lessmost November 3, 2020 06:59
@coveralls
Copy link

coveralls commented Nov 3, 2020

Pull Request Test Coverage Report for Build 343339769

  • 60 of 60 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 93.84%

Files with Coverage Reduction New Missed Lines %
src/adaptor/geometries/base.ts 1 98.32%
Totals Coverage Status
Change from base Build 342900845: 0.3%
Covered Lines: 3640
Relevant Lines: 3745

💛 - Coveralls

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2020

This pull request introduces 1 alert when merging f71929b into 0ad37a6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@hustcc hustcc merged commit 4978516 into master Nov 4, 2020
@hustcc hustcc deleted the feat-multi-layer branch November 4, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants