Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(word-cloud): word cloud should exec data-set transform when resize #1607

Merged
merged 1 commit into from
Sep 21, 2020
Merged

fix(word-cloud): word cloud should exec data-set transform when resize #1607

merged 1 commit into from
Sep 21, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Sep 21, 2020

  • word-cloud resize 的特殊处理逻辑

@auto-add-label auto-add-label bot added the Bug Something isn't working label Sep 21, 2020
@hustcc hustcc requested a review from zhangzhonghe September 21, 2020 07:15
@hustcc hustcc mentioned this pull request Sep 21, 2020
Merged
zhangzhonghe
zhangzhonghe approved these changes Sep 21, 2020
View reviewed changes
src/plots/word-cloud/index.ts
* 覆写父类的方法，因为词云图使用 data-set 进行布局，原理上有些不一样
*/
protected triggerResize() {
// 重新做一遍 data-set 的处理逻辑，这个适和其他图形不一样的地阿芳
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释错别字。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

啊啊啊，你一会帮忙改掉。

@zhangzhonghe zhangzhonghe merged commit c26ec95 into master Sep 21, 2020
@zhangzhonghe zhangzhonghe deleted the fix-wordcloud-resize branch September 21, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangzhonghe zhangzhonghe zhangzhonghe approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hustcc @zhangzhonghe