Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2/pie-demo): 饼图 demo 的优化 #1424

Merged
merged 3 commits into from
Aug 14, 2020
Merged

feat(v2/pie-demo): 饼图 demo 的优化 #1424

merged 3 commits into from
Aug 14, 2020

Conversation

visiky
Copy link
Member

@visiky visiky commented Aug 11, 2020 •
edited
Loading

  • 移除自定义复杂 label 的 demo
  • 移除 demo 中的 width, height配置，减少 plot 闪动
  • 修改饼图默认配置项（移除不必要的常量文件）
  • 增加 legend 类型定义

@auto-add-label auto-add-label bot added the enhancement New feature or request label Aug 11, 2020
@pr-triage pr-triage bot added the PR: draft label Aug 11, 2020
tests-checker[bot]
tests-checker bot suggested changes Aug 11, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@visiky visiky added this to the v2 milestone Aug 11, 2020
@visiky visiky marked this pull request as ready for review August 13, 2020 14:32
@visiky visiky requested review from hustcc and lxfu1 August 13, 2020 14:32
@hustcc hustcc merged commit 171ffd9 into v2 Aug 14, 2020
@hustcc hustcc deleted the fix/pie-v2-demo branch August 14, 2020 01:37
BBSQQ pushed a commit that referenced this pull request Aug 25, 2020
@visiky @BBSQQ
feat(v2/pie-demo): 饼图 demo 的优化 (#1424)
e2d56ad 
* feat(v2/pie-demo): 饼图 demo 的优化

* fix(typings): 修改 legend 的类型定义

* refactor(v2/pie): 设置中心指标卡默认样式，删除不必要的常量文件
BBSQQ pushed a commit that referenced this pull request Aug 25, 2020
@visiky @BBSQQ
feat(v2/pie-demo): 饼图 demo 的优化 (#1424)
8327b6e 
* feat(v2/pie-demo): 饼图 demo 的优化

* fix(typings): 修改 legend 的类型定义

* refactor(v2/pie): 设置中心指标卡默认样式，删除不必要的常量文件
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@hustcc hustcc hustcc approved these changes

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
enhancement New feature or request PR: merged
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.
2 participants
@visiky @hustcc