New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add demos #1423

Merged

hustcc merged 6 commits into v2 from feat/scatter-demos

Aug 12, 2020

Member

lxfu1 commented Aug 11, 2020

新增 scatter demos
新增 defaultConfig


          docs: add demos

auto-add-label bot added the documentation label

pr-triage bot added the PR: unreviewed label

tests-checker bot suggested changes

View reviewed changes

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

pr-triage bot added PR: reviewed-changes-requested and removed PR: unreviewed labels

lxfu1 assigned lessmost, hustcc and visiky

hustcc reviewed

View reviewed changes

__tests__/unit/plots/scatter/default-config-spec.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

examples/scatter/basic/demo/basic.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

examples/scatter/basic/demo/color-mapping.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

examples/scatter/basic/demo/label.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

examples/scatter/basic/demo/label.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

examples/scatter/basic/demo/shape-mapping.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

examples/scatter/basic/demo/size.ts Outdated Show resolved Hide resolved


          docs: review modify

c1fcb0a

pr-triage bot added PR: unreviewed and removed PR: reviewed-changes-requested labels


          fix: 修复默认配置引起的单测问题

39ed118

hustcc reviewed

View reviewed changes

src/config/index.ts Outdated Show resolved Hide resolved

src/plots/scatter/index.ts Outdated Show resolved Hide resolved

liufu.lf added 3 commits

August 12, 2020 08:57


          fix: review modify

6f81aba


          fix: 删除多余目录

7be642a


          fix: 删除多余空格

4d2d2bd

hustcc self-requested a review

August 12, 2020 02:46

hustcc approved these changes

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels

hustcc merged commit fa64dd6 into v2

hustcc deleted the feat/scatter-demos branch

August 12, 2020 02:54

pr-triage bot added PR: merged and removed PR: reviewed-approved labels

BBSQQ pushed a commit that referenced this pull request


          docs: add demos (#1423)

b316592

* docs: add demos

* docs: review modify

* fix: 修复默认配置引起的单测问题

* fix: review modify

* fix: 删除多余目录

* fix: 删除多余空格

Co-authored-by: liufu.lf <liufu.lf@antfin.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation PR: merged