Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job to validate Prepare-Node.ps1 #5862

Open
antoninbas opened this issue Jan 10, 2024 · 3 comments
Open

Add CI job to validate Prepare-Node.ps1 #5862

antoninbas opened this issue Jan 10, 2024 · 3 comments
Labels
area/OS/windows Issues or PRs related to the Windows operating system. area/test/jenkins Issue about jenkins setup code kind/task Categorizes issue or PR as related to a routine task that needs to be performed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@antoninbas
Copy link
Contributor

Prepare-Node.ps1 is meant to be run once when preparing a Windows Node for K8s / Antrea installation.
Since we provide our own customized script (instead of relying on https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/hostprocess/PrepareNode.ps1) and we point users to it in our Windows installation document, we should make sure that the script works correctly every time we cut a new Antrea release. This script is not currently exercised in our Windows CI jobs, as it is only run once to prepare worker Nodes when setting up the cluster (test clusters persist across CI jobs), and it is not run by the CI jobs themselves.
It would be a good idea to have an on-demand Jenkins job to validate the script, that we can trigger when we prepare a new release.

@antoninbas antoninbas added area/OS/windows Issues or PRs related to the Windows operating system. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/test/jenkins Issue about jenkins setup code kind/task Categorizes issue or PR as related to a routine task that needs to be performed labels Jan 10, 2024
@antoninbas
Copy link
Contributor Author

The job may be able to catch issues in Prepare-AntreaAgent.ps1 as well, such as #5852

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2024
@antoninbas antoninbas removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2024
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
@antoninbas antoninbas reopened this Oct 8, 2024
@antoninbas antoninbas added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/OS/windows Issues or PRs related to the Windows operating system. area/test/jenkins Issue about jenkins setup code kind/task Categorizes issue or PR as related to a routine task that needs to be performed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

1 participant