Skip to content

Commit f3c9471

Browse files
committed
fix: properly name everything
1 parent 601e935 commit f3c9471

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

src/cli/run.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* eslint-disable perfectionist/sort-objects */
2-
import type { ExtraLibrariesOption, FrameworkOption, LintScriptOption, PromptResult } from './types'
2+
import type { ExtraLibrariesOption, FrameworkOption, LintOption, PromptResult } from './types'
33

44
import fs from 'node:fs'
55
import path from 'node:path'
@@ -37,7 +37,7 @@ export async function run(options: CliRunOptions = {}): Promise<void> {
3737
const argSkipPrompt = !!process.env.SKIP_PROMPT || options.yes
3838
const argTemplate = <FrameworkOption[]>options.frameworks?.map(m => m?.trim()).filter(Boolean)
3939
const argExtra = <ExtraLibrariesOption[]>options.extra?.map(m => m?.trim()).filter(Boolean)
40-
const argLintScript = <LintScriptOption>options.lint?.trim()
40+
const argLint = <LintOption>options.lint?.trim()
4141

4242
if (fs.existsSync(path.join(process.cwd(), 'eslint.config.js'))) {
4343
p.log.warn(c.yellow`eslint.config.js already exists, migration wizard exited.`)
@@ -50,7 +50,7 @@ export async function run(options: CliRunOptions = {}): Promise<void> {
5050
frameworks: argTemplate ?? [],
5151
uncommittedConfirmed: false,
5252
updateVscodeSettings: true,
53-
lintScript: argLintScript ?? 'keep',
53+
lint: argLint ?? 'keep',
5454
}
5555

5656
if (!argSkipPrompt) {
@@ -106,13 +106,13 @@ export async function run(options: CliRunOptions = {}): Promise<void> {
106106
message: 'Update .vscode/settings.json for better VS Code experience?',
107107
})
108108
},
109-
lintScript: async ({ results }) => {
109+
lint: async ({ results }) => {
110110
if (!results.uncommittedConfirmed)
111111
return 'keep'
112112

113-
const isArgLintScriptValid = argLintScript && ['keep', 'check', 'fix'].includes(argLintScript)
114-
if (isArgLintScriptValid)
115-
return argLintScript
113+
const isArgLintValid = argLint && ['keep', 'check', 'fix'].includes(argLint)
114+
if (isArgLintValid)
115+
return argLint
116116

117117
const pkgPath = path.join(process.cwd(), 'package.json')
118118
const existingScript = fs.existsSync(pkgPath)

src/cli/stages/update-package-json.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ export async function updatePackageJson(result: PromptResult): Promise<void> {
2222
pkg.devDependencies ??= {}
2323

2424
// Handle lint script configuration
25-
if (result.lintScript !== 'keep') {
25+
if (result.lint !== 'keep') {
2626
pkg.scripts ??= {}
27-
pkg.scripts.lint = result.lintScript === 'fix'
27+
pkg.scripts.lint = result.lint === 'fix'
2828
? 'eslint --fix --cache'
2929
: 'eslint --cache'
3030
}

src/cli/types.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ export type FrameworkOption = 'vue' | 'react' | 'svelte' | 'astro' | 'solid' | '
88

99
export type ExtraLibrariesOption = 'formatter' | 'unocss'
1010

11-
export type LintScriptOption = 'keep' | 'check' | 'fix'
11+
export type LintOption = 'keep' | 'check' | 'fix'
1212

1313
export interface PromptResult {
1414
uncommittedConfirmed: boolean
1515
frameworks: FrameworkOption[]
1616
extra: ExtraLibrariesOption[]
1717
updateVscodeSettings: unknown
18-
lintScript: LintScriptOption
18+
lint: LintOption
1919
}

0 commit comments

Comments
 (0)