Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log "no votes" for non-savanna blocks #540

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 14, 2024

No need to track votes for legacy blocks.

Resolves #539

@heifner heifner added the OCI Work exclusive to OCI team label Aug 14, 2024
@heifner heifner merged commit 7beaa20 into main Aug 14, 2024
36 checks passed
@heifner heifner deleted the GH-539-no-vote-log branch August 14, 2024 18:51
@ericpassmore
Copy link
Contributor

Note:start
group: LOGGING
category: INTERNALS
summary: Do not log no-votes for pre-Savanna blocks.
Note: end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Block ... has no votes" logged on blocks prior to Savanna activation
4 participants