P2P: Fix net_plugin requesting same range repeatedly #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Aug 11, 2024
|
Note:start |
linh2931
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #472 Added additional unneeded check for
!sync_sourceinstart_syncto know if a sync was not already in progress. However, if the last request had received all the blocks from the previous request thensync_sourcewould already be reset. This sets up a race condition such that manystart_synccalls can kick off a new sync instead of continuing the current one.Also with #472 there is no need to reset
sync_next_expected_numback to received block when receiving a block already received. This just causes additional requests for blocks already received.Resolves #499