[1.0-beta4 -> main] Test: Reduce connection retry interval #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 15 seconds since many tests start multiple nodes at the same time and they need to connect to each other.
[1.0-beta4] Test: Reduce connection retry interval
greg7mdp
approved these changes
Jul 29, 2024
linh2931
approved these changes
Jul 29, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the integration tests start multiple nodes at the same time. Since a node can't connect until its peer is up in running this causes a situation where the first attempt to connect fails. The node then waits the default 30 seconds to attempt to reconnect. For the integration tests, reduce this from 30 seconds to 15 seconds. This should reduce the number of flakey failures due to a test running too slow.
Merges
release/1.0-beta4intomainincluding #430Resolves #424