Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use last_pending_finalizer_policy_start_timestamp instead of last_pending_finalizer_policy_start_num #414

Merged
merged 9 commits into from
Jul 26, 2024
Merged

Use last_pending_finalizer_policy_start_timestamp instead of last_pending_finalizer_policy_start_num #414

merged 9 commits into from
Jul 26, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Jul 26, 2024 •
edited
Loading

Resolves #412

See issue for background explanation for this change.

@linh2931
Merge pull request #411 from AntelopeIO/remove_final_on_strong
21bb5e9 
Remove final_on_strong_block_num from code base
@greg7mdp greg7mdp merged commit 76fbf10 into main Jul 26, 2024
36 checks passed
@greg7mdp greg7mdp deleted the gh_412 branch July 26, 2024 14:34
@ericpassmore
Copy link
Contributor

last_pending_finalizer_policy_start_timestamp
Note:start
group: STABILITY
category: INTERNALS
summary: Switch to timestamp for better detection of most recent policy change.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use last_pending_finalizer_policy_start_timestamp instead of last_pending_finalizer_policy_start_num
5 participants
@greg7mdp @ericpassmore @heifner @linh2931 @systemzax