Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify API for accessing controller's head #368

Merged
merged 14 commits into from
Jul 16, 2024
Merged

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Jul 15, 2024

Just provide access to head's block_handle, and use block_handle member functions to access:

  • block_num()
  • timestamp()
  • id()
  • etc...

This is just a removal of non-necessary access functions, there is no semantic change.

See discussion with @arhag .

block_handle::internal() was made private in previous PR.

@greg7mdp greg7mdp requested review from heifner and linh2931 July 15, 2024 19:09
@greg7mdp
Copy link
Contributor Author

I have updated the PR to also provide block_handle controller::fork_db_head() and deprecate other fork_db_head_* APIs.

@greg7mdp greg7mdp merged commit d06d5db into main Jul 16, 2024
36 checks passed
@greg7mdp greg7mdp deleted the head_api_simplification branch July 16, 2024 16:33
@greg7mdp greg7mdp added this to the Savanna: Production-Ready milestone Jul 16, 2024
@greg7mdp greg7mdp self-assigned this Jul 16, 2024
@ericpassmore
Copy link
Contributor

Note:start
group: CLEANCODE
category: INTERNALS
summary: Simplify API for accessing controller's head.
Note: end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants