Rename instant_finality_extension to finality_extension #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
reviewed
Jul 12, 2024
| @@ -183,7 +183,7 @@ void evaluate_finalizer_policies_for_promotion(const block_header_state& prev, | |||
| void finish_next(const block_header_state& prev, | |||
| block_header_state& next_header_state, | |||
| vector<digest_type> new_protocol_feature_activations, | |||
| instant_finality_extension if_ext, | |||
| finality_extension if_ext, | |||
There was a problem hiding this comment.
Maybe we should stop using if_ext, using fin_ext or f_int instead.
There was a problem hiding this comment.
Personally, I'd prefer avoiding such naming changes, I don't find if_ext objectionable, but I guess opinions may vary.
linh2931
approved these changes
Jul 12, 2024
greg7mdp
approved these changes
Jul 12, 2024
This was referenced Jul 15, 2024
linh2931
approved these changes
Jul 15, 2024
|
Note:start |
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #353