Reject a QC if bitset size of its strong_votes or weak_votes is invalid #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Jul 8, 2024
greg7mdp
approved these changes
Jul 8, 2024
unittests/block_state_tests.cpp
Outdated
| // create a valid_quorum_certificate | ||
| valid_quorum_certificate qc(strong_votes, {}, agg_sig); | ||
|
|
||
| BOOST_CHECK_EXCEPTION( bsp->verify_qc(qc), block_validate_exception, eosio::testing::fc_exception_message_starts_with("vote bitset size is not the same as the number of finalizers") ); |
There was a problem hiding this comment.
Why is the exception not invalid_qc_claim that is trigerred by the EOS_ASSERT?
There was a problem hiding this comment.
Thanks.
invalid_qc_claim is derived from block_validate_exception:
Used
block_validate_exception for keeping consistent with existing usage.
But it is better to be more specific. Changed all of the usages.
…CK_EXCEPTION to be more specific
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bitset size of strong_votes or weak_votes in q QC does not match the number of finalizers for the factive finalizer policy the QC refers to, reject the QC.
This PR also adds tests for the validation.
Resolves #334