Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: SHiP test: make test more reliable #327

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Test: SHiP test: make test more reliable #327

merged 1 commit into from
Jun 27, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 27, 2024 •
edited
Loading

Make test more reliable by waiting on next producer (c) to produce instead of only waiting on existing producer to produce. By waiting for producer c, this gives plenty of time for the non producing node to see producer b and shutdown.

Resolves #321

@heifner heifner added the OCI Work exclusive to OCI team label Jun 27, 2024
@heifner heifner requested review from linh2931 and greg7mdp June 27, 2024 18:23
@heifner heifner merged commit a9e4dcf into main Jun 27, 2024
36 checks passed
@heifner heifner deleted the GH-321-ship-test branch June 27, 2024 20:09
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Improve reliability of SHiP tests in continuous integration testing.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: ship_streamer_test
4 participants
@heifner @ericpassmore @greg7mdp @linh2931