[1.0-beta3 -> main] P2P: Fix multiple range requests while syncing #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b and causes more harm than good.
[1.0-beta2] P2P: Fix multiple range requests while syncing
…ync-requests-beta3
[1.0-beta2 -> 1,0-beta3] P2P: Fix multiple range requests while syncing
…ync-requests-main
linh2931
approved these changes
Jun 15, 2024
spoonincode
approved these changes
Jun 15, 2024
greg7mdp
approved these changes
Jun 15, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since blocks are processed immediately into the fork database when received, there is no longer any reason to request ahead of the existing range. Under normal circumstances a node will receive blocks from its peer and process them into the fork database. While those blocks are being applied additional blocks can be requested from the network. Care is taken to make sure that the fork database does not out run the chain head by more than
sync-fetch-span.Merges
release/1.0-beta3intomainincluding #291 & #294Resolves #281