Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Optimize test by minimizing voting #279

Merged
merged 8 commits into from
Jun 13, 2024
Merged

Test: Optimize test by minimizing voting #279

merged 8 commits into from
Jun 13, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 12, 2024

  • Only vote on the last three empty blocks of a set to optimize test time
  • Update tests to produce empty blocks where possible to speed up test time

Resolves #264

@heifner heifner added the OCI Work exclusive to OCI team label Jun 12, 2024
@heifner heifner requested review from greg7mdp and linh2931 June 12, 2024 18:59
greg7mdp
greg7mdp approved these changes Jun 13, 2024
View reviewed changes
libraries/testing/tester.cpp Outdated Show resolved Hide resolved
@heifner heifner merged commit 391be54 into main Jun 13, 2024
36 checks passed
@heifner heifner deleted the GH-264-test-voting branch June 13, 2024 17:56
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Speed up tests by avoiding unneeded BLS calculations. Part 1.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libtester voting optimizations
4 participants
@heifner @ericpassmore @greg7mdp @linh2931