Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta2 -> main] DeepMind: Add ID to ACCEPT_BLOCK_V2 #277

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 12, 2024

ACCEPT_BLOCK_V2

ACCEPTED_BLOCK_V2 ${id} ${num} ${lib} ${blk} ${fd}
${id} => block id
${num} => block number
${lib} => Last irreversible block number
${blk} => signed_block in fc packed hex format
${fd} => finality_data_t in fc packed hex format

finality_data_t

struct finality_data_t {
   uint32_t     major_version{light_header_protocol_version_major};
   uint32_t     minor_version{light_header_protocol_version_minor};
   uint32_t     active_finalizer_policy_generation{0};
   uint32_t     final_on_strong_qc_block_num{0};
   digest_type  action_mroot{};
   digest_type  base_digest{};
   std::optional<finalizer_policy> proposed_finalizer_policy; // finalizer policy, if proposed in the block
};
   struct finalizer_policy {
      uint32_t                         generation = 0; ///< sequentially incrementing version number
      uint64_t                         threshold = 0;  ///< vote weight threshold to finalize blocks
      std::vector<finalizer_authority> finalizers;     ///< Instant Finality voter set
   }
   struct finalizer_authority {
      std::string  description;
      uint64_t     weight = 0;
      fc::crypto::blslib::bls_public_key  public_key;
   }

bls_public_key is affine non-montgomery base64url with prefix PUB_BLS_

Merges release/1.0-beta2 into main including #276

Resolves #261

@heifner heifner requested review from linh2931 and greg7mdp June 12, 2024 01:21
@heifner heifner added the OCI Work exclusive to OCI team label Jun 12, 2024
@heifner heifner merged commit c428a7b into main Jun 12, 2024
36 checks passed
@heifner heifner deleted the GH-261-accept_block_v2-id-main branch June 12, 2024 02:17
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Add explicit ID to ACCEPT_BLOCK_V2 to improve DeepMind support.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep-mind ACCEPT_BLOCK_V2 changes
4 participants