Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cost (priority) to long running tests and split api_tests and wasm_tests #218

Merged
merged 5 commits into from
May 30, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented May 29, 2024

  • Set cost (priority) to long running tests so that they can start earlier
  • Split api_tests and wasm_tests further so that each can finish within CICD time limits

Resolves #210

@linh2931 linh2931 requested review from spoonincode and heifner May 29, 2024 19:35
@spoonincode
Copy link
Member

since memory_trap_1_check_throw_unit_test_eos_vm_oc is hitting the 7 minute timeout, maybe we can try increasing it to 8 minutes

ctest --output-on-failure -j $(nproc) -LE "(nonparallelizable_tests|long_running_tests)" --timeout 420

just based on the time ratio of other tests, 8 minutes might do it. But it's also cutting it close to the back end max of 10 minutes (which of course we can change if needed). All of this isn't ideal but that could be the easy quick fix to get green for now.

@linh2931
Copy link
Member Author

since memory_trap_1_check_throw_unit_test_eos_vm_oc is hitting the 7 minute timeout, maybe we can try increasing it to 8 minutes

ctest --output-on-failure -j $(nproc) -LE "(nonparallelizable_tests|long_running_tests)" --timeout 420

just based on the time ratio of other tests, 8 minutes might do it. But it's also cutting it close to the back end max of 10 minutes (which of course we can change if needed). All of this isn't ideal but that could be the easy quick fix to get green for now.

Wow, memory_trap_1_check_throw_unit_test_eos-vm-oc takes 449 seconds, dangerously close to the 480 seconds limit.

@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: CHORE
summary: Update test schedule to finish within CICD limits.
Note:end

@linh2931 linh2931 merged commit b90e35e into main May 30, 2024
36 checks passed
@linh2931 linh2931 deleted the set_tests_cost branch May 30, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test failure: wasm_part2_unit_test_eos-vm-oc timeout
4 participants