Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wasm_config_tests to run in both Legacy and Savanna #187

Merged
merged 5 commits into from
May 23, 2024
Merged

Update wasm_config_tests to run in both Legacy and Savanna #187

merged 5 commits into from
May 23, 2024

Conversation

linh2931
Copy link
Member

This one involves adapting BOOST_DATA_TEST_CASE_F.

Partially resolves #11

@linh2931 linh2931 requested review from heifner and spoonincode May 22, 2024 15:22
heifner
heifner requested changes May 22, 2024
View reviewed changes
Copy link
Member

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need split up like the other wasm tests.
2041/2043 Test #167: wasm_config_unit_test_eos-vm-oc .................... Passed 372.35 sec

@linh2931 linh2931 requested a review from heifner May 23, 2024 12:41
@linh2931 linh2931 merged commit c3a1e97 into main May 23, 2024
36 checks passed
@linh2931 linh2931 deleted the wasm_config_tests_both_modes branch May 23, 2024 18:32
@ericpassmore
Copy link
Contributor

ericpassmore commented May 24, 2024 •
edited
Loading

Note:start
group: STABILITY
category: TEST
summary: Update wasm config tests and access tests to work across various consensus modes.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@spoonincode spoonincode spoonincode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create IF versions of applicable unittests
4 participants
@linh2931 @ericpassmore @heifner @spoonincode