Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump appbase submodule for missing plugin name in exception message fix #164

Merged
merged 1 commit into from
May 20, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented May 18, 2024

Bring in the fix for missing plugin name in exception message from Appbase.

#155 reports an unclear error message:
appbase: exception thrown during plugin "" initialization.

I saw the same issue when dirty db happened:

 N5boost10wrapexceptISt12system_errorEE: Database dirty flag set
 rethrow Database dirty flag set:
    {"what":"Database dirty flag set"}
      nodeos  chain_plugin.cpp:1097 plugin_initialize

 appbase: exception thrown during plugin "" initialization.

Resolves #155

@linh2931 linh2931 requested review from spoonincode and heifner May 18, 2024 21:11
Copy link
Member

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like something we should consider sending back to 5.0

@linh2931 linh2931 merged commit a781609 into main May 20, 2024
36 checks passed
@linh2931 linh2931 deleted the bump_appbase branch May 20, 2024 12:29
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: LOGGING
summary: Include name of missing plugin, when logging an appbase exception.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear error message when setting allowed-connection=specified and not providing any peer-key
4 participants