Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct finalizer_policy for logging #105

Merged
merged 3 commits into from
May 2, 2024
Merged

Use correct finalizer_policy for logging #105

merged 3 commits into from
May 2, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented May 2, 2024

The active finalizer policy associated with the qc should be used when logging the qc, not the head block finalizer policy.

Resolves #103

@heifner heifner added the OCI Work exclusive to OCI team label May 2, 2024
@heifner heifner requested review from greg7mdp and linh2931 May 2, 2024 19:17
@heifner heifner merged commit e825f68 into main May 2, 2024
36 checks passed
@heifner heifner deleted the GH-103-log-assert branch May 2, 2024 22:21
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Use the correct finalizer policy when logging.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log_missing_votes assert failure
4 participants