Perf issue: avoid vector copy at each insertion. #2327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vector::reserve(vector::size() + 1)
call which is updated in this PR, with typicalstd::vector
implementations, causes the vector to grow by a single element on every reverve, and therefore a memory allocation and full vector copy on everyreserve
call.This updates the
reserve()
call so that the vector capacity grows quadrically.