fix net_plugin_impl destruction order: destroy thread_pool's executor after users of it
#2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Mar 11, 2024
| if( keepalive_timer ) | ||
| keepalive_timer->cancel(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Didn't see a reason for these cancellations. The timers will effectively be stopped once the named_thread_pool is stopped.
greg7mdp
approved these changes
Mar 11, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net_plugin_implcurrently destroys itsnamed_thread_poolbefore a number of users of it such asexpire_timer. Those users can, and do, access their executor on their destruction which in this case is accessing an already destroyed executor.Move the
named_thread_poolup to the top so it's destroyed last. A nice side effect of this is being able to clean up a number of theunique_ptrs to just being a plain member.