Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create performance harness module #1535

Merged
merged 6 commits into from
Aug 28, 2023

Conversation

oschwaldp-oci
Copy link
Contributor

Refactor performance_test* into PerformanceHarness module

Create PerformanceHarness python module and convert performance_test.py and performance_test_basic.py and other support scripts into that module.

Create Performance Harness runner(s) that import PerformanceHarness and run tests.

Performance Harness is being moved into a python module, this is the first prep step.
Added PerformanceHarnessScenarioRunner to import PerformanceHarness module and allow configuring and running test scenarios previously directly accessible through performance_test.py and performance_test_basic.py which are now contained in the module.
@heifner heifner added the OCI Work exclusive to OCI team label Aug 18, 2023
Copy link
Contributor

@ericpassmore ericpassmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to discuss nodeos version. Aside from that one issue, this PR LGTM.

@BenjaminGormanPMP BenjaminGormanPMP removed the request for review from dimas1185 August 21, 2023 21:21
Copy link
Contributor

@ericpassmore ericpassmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oschwaldp-oci oschwaldp-oci merged commit efae4ee into main Aug 28, 2023
@oschwaldp-oci oschwaldp-oci deleted the create-performance-harness-module branch August 28, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants