From 420dc5d4f520eccdadb8fca2e9da46890936e6f1 Mon Sep 17 00:00:00 2001 From: svandenb-dev Date: Thu, 23 Jan 2025 15:22:08 +0100 Subject: [PATCH 1/5] conformal waveport extension --- .../generate_arbitrary_wave_ports.py | 21 ++++--------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py b/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py index 2e7469b6b36..9dd6a27542c 100644 --- a/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py +++ b/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py @@ -237,7 +237,6 @@ def main(extension_args): "selected the correct mounting side. The selected side must " "must contain explicit voids with pad-stack instances inside.", ) - signal_nets = list(edb.nets.signal.keys()) edb.close() time.sleep(1) @@ -259,24 +258,12 @@ def main(extension_args): hfss.solution_type = "Modal" # Deleting dielectric objects - [obj.delete() for obj in hfss.modeler.solid_objects if obj.material_name in hfss.modeler.materials.dielectrics] + obj_del = [obj for obj in hfss.modeler.solid_objects if obj.material_name in hfss.modeler.materials.dielectrics] + for obj in obj_del: + obj.delete() # creating ports - sheets_for_ports = hfss.modeler.sheet_objects - terminal_faces = [] - terminal_objects = [obj for obj in hfss.modeler.object_list if obj.name in signal_nets] - for obj in terminal_objects: - if mounting_side_variable == "bottom": - face = obj.bottom_face_z - else: - face = obj.top_face_z - terminal_face = hfss.modeler.create_object_from_face(face.id, non_model=False) - hfss.assign_perfecte_to_sheets(terminal_face.name) - name = obj.name - terminal_faces.append(terminal_face) - obj.delete() - terminal_face.name = name - for sheet in sheets_for_ports: + for sheet in hfss.modeler.sheet_objects: hfss.wave_port(assignment=sheet.id, reference="GND", terminals_rename=False) # create 3D component From f13db4e9b6662f5d7d7aab86935755a8a7f293a6 Mon Sep 17 00:00:00 2001 From: svandenb-dev Date: Thu, 23 Jan 2025 15:58:36 +0100 Subject: [PATCH 2/5] conformal waveport extension --- .../hfss3dlayout/generate_arbitrary_wave_ports.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py b/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py index 9dd6a27542c..d31ed9c6031 100644 --- a/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py +++ b/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py @@ -258,12 +258,13 @@ def main(extension_args): hfss.solution_type = "Modal" # Deleting dielectric objects - obj_del = [obj for obj in hfss.modeler.solid_objects if obj.material_name in hfss.modeler.materials.dielectrics] - for obj in obj_del: + for obj in [ + obj for obj in hfss.modeler.solid_objects if obj.material_name in hfss.modeler.materials.dielectrics + ]: # pragma no cover obj.delete() # creating ports - for sheet in hfss.modeler.sheet_objects: + for sheet in hfss.modeler.sheet_objects: # pragma no cover hfss.wave_port(assignment=sheet.id, reference="GND", terminals_rename=False) # create 3D component From 6828188acd74b3b4f6d532c098208d8f7d804a3e Mon Sep 17 00:00:00 2001 From: svandenb-dev <74993647+svandenb-dev@users.noreply.github.com> Date: Fri, 24 Jan 2025 09:30:27 +0100 Subject: [PATCH 3/5] Update src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> --- .../workflows/hfss3dlayout/generate_arbitrary_wave_ports.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py b/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py index d31ed9c6031..582f16a1859 100644 --- a/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py +++ b/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py @@ -258,10 +258,10 @@ def main(extension_args): hfss.solution_type = "Modal" # Deleting dielectric objects - for obj in [ + for solid_obj in [ obj for obj in hfss.modeler.solid_objects if obj.material_name in hfss.modeler.materials.dielectrics - ]: # pragma no cover - obj.delete() + ]: + solid_obj.delete() # creating ports for sheet in hfss.modeler.sheet_objects: # pragma no cover From 9700b3246b0a23e402426c9a112b9b79e2d120bb Mon Sep 17 00:00:00 2001 From: svandenb-dev <74993647+svandenb-dev@users.noreply.github.com> Date: Fri, 24 Jan 2025 09:30:36 +0100 Subject: [PATCH 4/5] Update src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> --- .../workflows/hfss3dlayout/generate_arbitrary_wave_ports.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py b/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py index 582f16a1859..4fd40b9560d 100644 --- a/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py +++ b/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py @@ -264,7 +264,7 @@ def main(extension_args): solid_obj.delete() # creating ports - for sheet in hfss.modeler.sheet_objects: # pragma no cover + for sheet in hfss.modeler.sheet_objects: hfss.wave_port(assignment=sheet.id, reference="GND", terminals_rename=False) # create 3D component From 87276c42b7f86bfec8a2adc71a7287c4a1816dc1 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 24 Jan 2025 08:31:45 +0000 Subject: [PATCH 5/5] CHORE: Auto fixes from pre-commit.com hooks For more information, see https://pre-commit.ci --- .../workflows/hfss3dlayout/generate_arbitrary_wave_ports.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py b/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py index 4fd40b9560d..e423dc9f02e 100644 --- a/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py +++ b/src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py @@ -260,7 +260,7 @@ def main(extension_args): # Deleting dielectric objects for solid_obj in [ obj for obj in hfss.modeler.solid_objects if obj.material_name in hfss.modeler.materials.dielectrics - ]: + ]: solid_obj.delete() # creating ports