From 3b2d6b84e41a794fac4a316f83d3aed9a696bc64 Mon Sep 17 00:00:00 2001 From: lorenzovecchietti Date: Thu, 10 Oct 2024 17:58:27 +0200 Subject: [PATCH 1/5] fix: select user specified settings more reliably --- src/ansys/aedt/core/modules/mesh_icepak.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/ansys/aedt/core/modules/mesh_icepak.py b/src/ansys/aedt/core/modules/mesh_icepak.py index 423037f396b..128242a1679 100644 --- a/src/ansys/aedt/core/modules/mesh_icepak.py +++ b/src/ansys/aedt/core/modules/mesh_icepak.py @@ -511,10 +511,7 @@ def parse_settings_as_args(self): if k in ["MaxElementSizeX", "MaxElementSizeY", "MaxElementSizeZ", "MinGapX", "MinGapY", "MinGapZ"]: v = _dim_arg(v, getattr(self._mesh_class, "_model_units")) out.append(v) - out.append( - "UserSpecifiedSettings:=", - ) - out.append("MeshRegionResolution" in self.keys()) + out += ["UserSpecifiedSettings:=", getattr(self._mesh_class, "manual_settings")] return out def parse_settings_as_dictionary(self): From f353c7b9856738ee4a09b37fc99a99bee80faad5 Mon Sep 17 00:00:00 2001 From: lorenzovecchietti Date: Fri, 11 Oct 2024 09:19:00 +0200 Subject: [PATCH 2/5] apply codacity suggestion --- src/ansys/aedt/core/modules/mesh_icepak.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/aedt/core/modules/mesh_icepak.py b/src/ansys/aedt/core/modules/mesh_icepak.py index 128242a1679..38208fc6647 100644 --- a/src/ansys/aedt/core/modules/mesh_icepak.py +++ b/src/ansys/aedt/core/modules/mesh_icepak.py @@ -1195,7 +1195,7 @@ def assign_mesh_level(self, mesh_order, name=None): """ level_order = {} for obj in mesh_order: - if mesh_order[obj] not in level_order.keys(): + if mesh_order[obj] not in level_order: level_order[mesh_order[obj]] = [] level_order[mesh_order[obj]].append(obj) list_meshops = [] From cde6c0b9c71fda84b77a34fd14c819cc46a5cab4 Mon Sep 17 00:00:00 2001 From: Lorenzo Vecchietti <58366962+lorenzovecchietti@users.noreply.github.com> Date: Mon, 14 Oct 2024 09:36:35 +0200 Subject: [PATCH 3/5] Update src/ansys/aedt/core/modules/mesh_icepak.py MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> --- src/ansys/aedt/core/modules/mesh_icepak.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/aedt/core/modules/mesh_icepak.py b/src/ansys/aedt/core/modules/mesh_icepak.py index 38208fc6647..4b87b8cea09 100644 --- a/src/ansys/aedt/core/modules/mesh_icepak.py +++ b/src/ansys/aedt/core/modules/mesh_icepak.py @@ -509,7 +509,7 @@ def parse_settings_as_args(self): for k, v in self._instance_settings.items(): out.append(k + ":=") if k in ["MaxElementSizeX", "MaxElementSizeY", "MaxElementSizeZ", "MinGapX", "MinGapY", "MinGapZ"]: - v = _dim_arg(v, getattr(self._mesh_class, "_model_units")) + v = _dim_arg(v, self._mesh_class._model_units) out.append(v) out += ["UserSpecifiedSettings:=", getattr(self._mesh_class, "manual_settings")] return out From 00675199a7abf00862139c3c9f17d5034c2ec2c9 Mon Sep 17 00:00:00 2001 From: Lorenzo Vecchietti <58366962+lorenzovecchietti@users.noreply.github.com> Date: Mon, 14 Oct 2024 09:36:41 +0200 Subject: [PATCH 4/5] Update src/ansys/aedt/core/modules/mesh_icepak.py MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> --- src/ansys/aedt/core/modules/mesh_icepak.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/aedt/core/modules/mesh_icepak.py b/src/ansys/aedt/core/modules/mesh_icepak.py index 4b87b8cea09..330da0d6d8c 100644 --- a/src/ansys/aedt/core/modules/mesh_icepak.py +++ b/src/ansys/aedt/core/modules/mesh_icepak.py @@ -511,7 +511,7 @@ def parse_settings_as_args(self): if k in ["MaxElementSizeX", "MaxElementSizeY", "MaxElementSizeZ", "MinGapX", "MinGapY", "MinGapZ"]: v = _dim_arg(v, self._mesh_class._model_units) out.append(v) - out += ["UserSpecifiedSettings:=", getattr(self._mesh_class, "manual_settings")] + out += ["UserSpecifiedSettings:=", self._mesh_class.manual_settings)] return out def parse_settings_as_dictionary(self): From 8c7af07fba13f38e604a62975e6d7fdda71aa49b Mon Sep 17 00:00:00 2001 From: Lorenzo Vecchietti <58366962+lorenzovecchietti@users.noreply.github.com> Date: Mon, 14 Oct 2024 09:46:26 +0200 Subject: [PATCH 5/5] FIX: syntax error --- src/ansys/aedt/core/modules/mesh_icepak.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/aedt/core/modules/mesh_icepak.py b/src/ansys/aedt/core/modules/mesh_icepak.py index 330da0d6d8c..2d906ea4a7c 100644 --- a/src/ansys/aedt/core/modules/mesh_icepak.py +++ b/src/ansys/aedt/core/modules/mesh_icepak.py @@ -511,7 +511,7 @@ def parse_settings_as_args(self): if k in ["MaxElementSizeX", "MaxElementSizeY", "MaxElementSizeZ", "MinGapX", "MinGapY", "MinGapZ"]: v = _dim_arg(v, self._mesh_class._model_units) out.append(v) - out += ["UserSpecifiedSettings:=", self._mesh_class.manual_settings)] + out += ["UserSpecifiedSettings:=", self._mesh_class.manual_settings] return out def parse_settings_as_dictionary(self):