diff --git a/pyaedt/desktop.py b/pyaedt/desktop.py index 58a2f0908eb..88dda626451 100644 --- a/pyaedt/desktop.py +++ b/pyaedt/desktop.py @@ -945,10 +945,10 @@ def _initialize( self.is_grpc_api = True last_session.parent_desktop_id.append(self.aedt_process_id) return True - except: + except Exception: messages = desktop.GetMessages("", "", 0) for message in messages: - if " GRPC server running on port: " in message and str(port) in message: + if "gRPC server running on port: " in message and str(port) in message: self.isoutsideDesktop = True self.odesktop = desktop self.aedt_process_id = self.odesktop.GetProcessID() diff --git a/pyaedt/generic/ibis_reader.py b/pyaedt/generic/ibis_reader.py index 3ab2b6ed525..b6c99e129a7 100644 --- a/pyaedt/generic/ibis_reader.py +++ b/pyaedt/generic/ibis_reader.py @@ -415,7 +415,7 @@ def add(self): [], ], ) - except: + except Exception: logger.error("Error adding {} pin component.".format(self.short_name)) return False diff --git a/pyaedt/generic/touchstone_parser.py b/pyaedt/generic/touchstone_parser.py index 0a3cc8d6ab1..3442529ee94 100644 --- a/pyaedt/generic/touchstone_parser.py +++ b/pyaedt/generic/touchstone_parser.py @@ -267,7 +267,7 @@ def get_return_loss_index(self, excitation_name_prefix=""): Returns ------- list - list of index couples representing Return Losses of excitations + List of index couples representing return losses of excitations. """ values = [] @@ -545,9 +545,9 @@ def check_touchstone_files(folder="", passivity=True, causality=True): causality_check = float(msg_log.split("Maximum causality error: ")[-1].split("for entry")[0]) if not causality_check == 0.0: is_causal = False - except: + except Exception: is_causal = False - raise Exception("Failed evaluating causality value") + raise Exception("Failed evaluating causality value.") out[snpf].append(["causality", is_causal, msg_log]) if "Causality check is inconclusive" in line and causality: is_causal = False diff --git a/pyaedt/hfss.py b/pyaedt/hfss.py index da25281f5f5..d31c96859bc 100644 --- a/pyaedt/hfss.py +++ b/pyaedt/hfss.py @@ -3757,34 +3757,34 @@ def thicken_port_sheets(self, assignment, value, extrude_internally=True, intern directions = {} for el in assignment: objID = self.modeler.oeditor.GetFaceIDs(el) - faceCenter = self.modeler.oeditor.GetFaceCenter(int(objID[0])) - directionfound = False - l = min(aedt_bounding_dim) / 2 - while not directionfound: + face_center = self.modeler.oeditor.GetFaceCenter(int(objID[0])) + direction_found = False + thickness = min(aedt_bounding_dim) / 2 + while not direction_found: self.modeler.oeditor.ThickenSheet( ["NAME:Selections", "Selections:=", el, "NewPartsModelFlag:=", "Model"], - ["NAME:SheetThickenParameters", "Thickness:=", str(l) + "mm", "BothSides:=", False], + ["NAME:SheetThickenParameters", "Thickness:=", str(thickness) + "mm", "BothSides:=", False], ) - # aedt_bounding_box2 = self.oeditor.GetModelBoundingBox() + aedt_bounding_box2 = self.modeler.get_model_bounding_box() self._odesign.Undo() if aedt_bounding_box != aedt_bounding_box2: directions[el] = "External" - directionfound = True + direction_found = True self.modeler.oeditor.ThickenSheet( ["NAME:Selections", "Selections:=", el, "NewPartsModelFlag:=", "Model"], - ["NAME:SheetThickenParameters", "Thickness:=", "-" + str(l) + "mm", "BothSides:=", False], + ["NAME:SheetThickenParameters", "Thickness:=", "-" + str(thickness) + "mm", "BothSides:=", False], ) - # aedt_bounding_box2 = self.oeditor.GetModelBoundingBox() + aedt_bounding_box2 = self.modeler.get_model_bounding_box() self._odesign.Undo() if aedt_bounding_box != aedt_bounding_box2: directions[el] = "Internal" - directionfound = True + direction_found = True else: - l = l + min(aedt_bounding_dim) / 2 + thickness = thickness + min(aedt_bounding_dim) / 2 for el in assignment: objID = self.modeler.oeditor.GetFaceIDs(el) maxarea = 0 @@ -3792,7 +3792,7 @@ def thicken_port_sheets(self, assignment, value, extrude_internally=True, intern faceArea = self.modeler.get_face_area(int(f)) if faceArea > maxarea: maxarea = faceArea - faceCenter = self.modeler.oeditor.GetFaceCenter(int(f)) + face_center = self.modeler.oeditor.GetFaceCenter(int(f)) if directions[el] == "Internal": self.modeler.oeditor.ThickenSheet( ["NAME:Selections", "Selections:=", el, "NewPartsModelFlag:=", "Model"], @@ -3810,8 +3810,8 @@ def thicken_port_sheets(self, assignment, value, extrude_internally=True, intern fc2 = self.modeler.oeditor.GetFaceCenter(f) fc2 = [float(i) for i in fc2] fa2 = self.modeler.get_face_area(int(f)) - faceoriginal = [float(i) for i in faceCenter] - # dist = mat.sqrt(sum([(a*a-b*b) for a,b in zip(faceCenter, fc2)])) + faceoriginal = [float(i) for i in face_center] + # dist = mat.sqrt(sum([(a*a-b*b) for a,b in zip(face_center, fc2)])) if abs(fa2 - maxarea) < tol**2 and ( abs(faceoriginal[2] - fc2[2]) > tol or abs(faceoriginal[1] - fc2[1]) > tol @@ -3832,8 +3832,8 @@ def thicken_port_sheets(self, assignment, value, extrude_internally=True, intern objID2 = self.modeler.oeditor.GetFaceIDs(el) for fid in objID2: try: - faceCenter2 = self.modeler.oeditor.GetFaceCenter(int(fid)) - if faceCenter2 == faceCenter: + face_center2 = self.modeler.oeditor.GetFaceCenter(int(fid)) + if face_center2 == face_center: self.modeler.oeditor.MoveFaces( ["NAME:Selections", "Selections:=", el, "NewPartsModelFlag:=", "Model"], [ @@ -3857,7 +3857,6 @@ def thicken_port_sheets(self, assignment, value, extrude_internally=True, intern ) except Exception: self.logger.info("done") - # self.modeler_oproject.ClearMessages() return ports_ID @pyaedt_function_handler(dname="design", ouputdir="ouput_dir") diff --git a/pyaedt/modeler/cad/Primitives.py b/pyaedt/modeler/cad/Primitives.py index 9292fde8307..b4bfdf71cff 100644 --- a/pyaedt/modeler/cad/Primitives.py +++ b/pyaedt/modeler/cad/Primitives.py @@ -137,7 +137,7 @@ def __getitem__(self, item): o = self.__parent._create_object(name, id) self.__setitem__(id, o) return o - except: + except Exception: raise KeyError(item) elif isinstance(item, str): @@ -147,7 +147,7 @@ def __getitem__(self, item): o = self.__parent._create_object(name, id) self.__setitem__(id, o) return o - except: + except Exception: raise KeyError(item) elif isinstance(item, (Object3d, Polyline)): @@ -208,7 +208,7 @@ def __getitem__(self, partId): return partId try: return self.objects[partId] - except: + except Exception: if partId in self.user_defined_components.keys(): return self.user_defined_components[partId] self.logger.error("Object '{}' not found.".format(partId)) @@ -846,13 +846,13 @@ def _refresh_all_ids_from_aedt_file(self): if operations and isinstance(operations.get("Operation", None), (OrderedDict, dict)): try: pid = operations["Operation"]["ParentPartID"] - except Exception: # pragma: no cover - pass + except Exception as e: # pragma: no cover + self.logger.debug(e) elif operations and isinstance(operations.get("Operation", None), list): try: pid = operations["Operation"][0]["ParentPartID"] - except Exception: - pass + except Exception as e: + self.logger.debug(e) is_polyline = False if operations and "PolylineParameters" in operations.get("Operation", {}): @@ -1230,14 +1230,14 @@ def _get_coordinates_data(self): # pragma: no cover props = iop["FaceCSParameters"] coord.append(FaceCoordinateSystem(self, props, name)) break - except Exception: - pass + except Exception as e: + self.logger.debug(e) for cs in coord: if isinstance(cs, CoordinateSystem): try: cs._ref_cs = id2name[name2refid[cs.name]] - except Exception: - pass + except Exception as e: + self.logger.debug(e) coord.reverse() return coord @@ -8275,7 +8275,7 @@ def _create_object(self, name, pid=0, use_cached=False, is_polyline=False, **kwa except Exception: self.logger.warning("Unable to assign " + str(k) + " to object " + o.name + ".") else: - self.logger.error("'" + str(k) + "' is not a valid property of the primitive ") + self.logger.debug("'" + str(k) + "' is not a valid property of the primitive.") return o @pyaedt_function_handler() diff --git a/pyaedt/modules/MeshIcepak.py b/pyaedt/modules/MeshIcepak.py index ae868d9946c..2292e8b5323 100644 --- a/pyaedt/modules/MeshIcepak.py +++ b/pyaedt/modules/MeshIcepak.py @@ -341,7 +341,7 @@ def create(self, padding_values, padding_types, region_name, parts): Returns ------- bool - True if successful, else False + ``True`` when successful, ``False`` when failed. """ try: if ( @@ -355,7 +355,7 @@ def create(self, padding_values, padding_types, region_name, parts): objects = [o.name for o in objects] self._app.modeler.create_subregion(padding_values, padding_types, parts, region_name) return True - except: + except Exception: return False def delete(self): @@ -365,7 +365,7 @@ def delete(self): Returns ------- bool - True if successful, else False + ``True`` when successful, ``False`` when failed. """ try: self.object.delete() @@ -540,9 +540,9 @@ class MeshRegionCommon(object): name : str Name of the mesh region. manual_settings : bool - Whether to use manual settings or automatic ones. - settings : ::class::modules.MeshIcepak.MeshSettings - Dictionary-like object to handle settings + Whether to use manual settings. If ``False``, automatic settings are used. + settings : :class:`modules.MeshIcepak.MeshSettings` + Dictionary-like object to handle settings. """ def __init__(self, units, app, name):