From c8a030b55745e134feeb0bbb735a48e5003f619d Mon Sep 17 00:00:00 2001
From: Devin <devin.crawford@ansys.com>
Date: Sat, 28 Dec 2024 13:27:10 +0100
Subject: [PATCH] Correct error to HFSS Setup default type #5618

\ansys\aedt\core\modules\setup_templates.py
- Change autosweep default from "LinearStep" to "LinearCount" to match the default behavior of HFSS.
- Use "RangeCount": 501

\ansys\aedt\core\hfss.py
- Update docstring errors for create_setup()

\ansys\aedt\core\application.py
- Change default setup from 1 to 0 for HFSS where appropriate.

\ansys\aedt\core\application\analysis.py
- Correct an error that would always use an auto-generated name for the setup.
---
 src/ansys/aedt/core/application/analysis.py         | 3 ++-
 src/ansys/aedt/core/application/design_solutions.py | 8 ++++----
 src/ansys/aedt/core/hfss.py                         | 3 +--
 src/ansys/aedt/core/modules/setup_templates.py      | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/ansys/aedt/core/application/analysis.py b/src/ansys/aedt/core/application/analysis.py
index 494e4b58d8c..284f38fe1df 100644
--- a/src/ansys/aedt/core/application/analysis.py
+++ b/src/ansys/aedt/core/application/analysis.py
@@ -1355,7 +1355,8 @@ def _create_setup(self, name="MySetupAuto", setup_type=None, props=None):
 
         if setup_type is None:
             setup_type = self.design_solutions.default_setup
-        name = self.generate_unique_setup_name(name)
+        if not name:
+            name = self.generate_unique_setup_name(name)
         if setup_type == 0:
             setup = SetupHFSSAuto(self, setup_type, name)
         elif setup_type == 4:
diff --git a/src/ansys/aedt/core/application/design_solutions.py b/src/ansys/aedt/core/application/design_solutions.py
index 8531a688e7b..df7fad37feb 100644
--- a/src/ansys/aedt/core/application/design_solutions.py
+++ b/src/ansys/aedt/core/application/design_solutions.py
@@ -342,7 +342,7 @@
             "name": "HFSS Modal Network",
             "options": None,
             "report_type": "Modal Solution Data",
-            "default_setup": 1,
+            "default_setup": 0,
             "default_adaptive": "LastAdaptive",
             "intrinsics": ["Freq", "Phase"],
         },
@@ -350,7 +350,7 @@
             "name": "HFSS Terminal Network",
             "options": None,
             "report_type": "Terminal Solution Data",
-            "default_setup": 1,
+            "default_setup": 0,
             "default_adaptive": "LastAdaptive",
             "intrinsics": ["Freq", "Phase"],
         },
@@ -358,7 +358,7 @@
             "name": "DrivenModal",
             "options": None,
             "report_type": "Modal Solution Data",
-            "default_setup": 1,
+            "default_setup": 0,
             "default_adaptive": "LastAdaptive",
             "intrinsics": ["Freq", "Phase"],
         },
@@ -366,7 +366,7 @@
             "name": "DrivenTerminal",
             "options": None,
             "report_type": "Terminal Solution Data",
-            "default_setup": 1,
+            "default_setup": 0,
             "default_adaptive": "LastAdaptive",
             "intrinsics": ["Freq", "Phase"],
         },
diff --git a/src/ansys/aedt/core/hfss.py b/src/ansys/aedt/core/hfss.py
index 3183bbaa4cf..8c742252720 100644
--- a/src/ansys/aedt/core/hfss.py
+++ b/src/ansys/aedt/core/hfss.py
@@ -811,8 +811,7 @@ def create_setup(self, name="MySetupAuto", setup_type=None, **kwargs):
             ``"HFSSDrivenAuto"``, ``"HFSSDrivenDefault"``, ``"HFSSEigen"``, ``"HFSSTransient"``,
             and ``"HFSSSBR"``. The default is ``"HFSSDrivenAuto"``.
         **kwargs : dict, optional
-            Extra arguments to set up the circuit.
-            Available keys depend on the setup chosen.
+            Keyword arguments from the native AEDT API.
             For more information, see
             :doc:`../SetupTemplatesHFSS`.
 
diff --git a/src/ansys/aedt/core/modules/setup_templates.py b/src/ansys/aedt/core/modules/setup_templates.py
index 9f47b9e38f4..cf6b08f21c0 100644
--- a/src/ansys/aedt/core/modules/setup_templates.py
+++ b/src/ansys/aedt/core/modules/setup_templates.py
@@ -47,7 +47,7 @@ def HFSS3DLayout_AdaptiveFrequencyData(freq):
 
 
 meshlink = dict({"ImportMesh": False})
-autosweep = dict({"RangeType": "LinearStep", "RangeStart": "1GHz", "RangeEnd": "10GHz", "RangeStep": "1GHz"})
+autosweep = dict({"RangeType": "LinearCount", "RangeStart": "1GHz", "RangeEnd": "10GHz", "RangeCount": "501"})
 autosweeps = dict({"Sweep": autosweep})
 multifreq = dict({"1GHz": [0.02], "2GHz": [0.02], "5GHz": [0.02]})
 sweepsbr = dict({"RangeType": "LinearStep", "RangeStart": "1GHz", "RangeEnd": "10GHz", "RangeStep": "1GHz"})