Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications Assigned to Workflows Don't Send Properly When Assigned at Org Level #4712

Closed
beeankha opened this issue Sep 11, 2019 · 2 comments
Closed

Notifications Assigned to Workflows Don't Send Properly When Assigned at Org Level #4712

beeankha opened this issue Sep 11, 2019 · 2 comments
Assignees
@beeankha
Labels
component:api type:bug

Comments

@beeankha
Copy link
Contributor

ISSUE TYPE
  • Bug Report
SUMMARY

Related to a specific comment in this PR: #4657 (comment)

The failure, success, and started notification templates for Workflows do not inherit from the Organization even though they should. We have approval notifications inherit from the Org (per PR #4657); the other notification types needs to be changed in order to send notifications for workflows when the notification templates are assigned at the Org level.
@beeankha beeankha self-assigned this Sep 11, 2019
@ryanpetrello
Copy link
Contributor

follow-on work from @beeankha's WF approval changes

@wenottingham wenottingham mentioned this issue Sep 13, 2019
Merged
@beeankha beeankha mentioned this issue Oct 7, 2019
Merged
@beeankha
Copy link
Contributor Author

beeankha commented Oct 9, 2019

Closing this issue due to #4933 being merged!

@beeankha beeankha closed this as completed Oct 9, 2019
@ryanpetrello ryanpetrello reopened this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beeankha beeankha

Labels
component:api type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ryanpetrello @beeankha @kdelee