Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NetApp ONTAP user module #20723

Merged
merged 3 commits into from
Feb 14, 2017
Merged

Add NetApp ONTAP user module #20723

merged 3 commits into from
Feb 14, 2017

Conversation

timuster
Copy link
Contributor

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

NetApp ONTAP user module

ANSIBLE VERSION
ansible 2.3.0
  config file = 
  configured module search path = Default w/o overrides
SUMMARY

Adding na_cdot_user.py, a module to manage NetApp ONTAP users. The design was based on the existing NetApp E-Series modules.

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. labels Jan 26, 2017
@ansibot
Copy link
Contributor

ansibot commented Jan 27, 2017

@hulquest

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jan 27, 2017
@hulquest
Copy link
Contributor

LGTM.
shipit

@timuster timuster force-pushed the netapp-ontap-module-user branch from 4345730 to a785a11 Compare February 10, 2017 20:53
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 10, 2017
mattclay
mattclay reviewed Feb 11, 2017
View reviewed changes
lib/ansible/modules/storage/netapp/na_cdot_user.py Outdated
authentication_method:
description:
- Authentication method for the application.
- Not all authentication methods are valid for an application. Valid authentication methods for each application are as denoted in I(authentication_choices_description).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure due to:

2017-02-10 20:57:26 ERROR: PEP 8: lib/ansible/modules/storage/netapp/na_cdot_user.py:59:161: E501 line too long (173 > 160 characters) (current)

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 11, 2017
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 11, 2017
@hulquest
Copy link
Contributor

shipit

1 similar comment
@lmprice
Copy link
Contributor

lmprice commented Feb 13, 2017

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 13, 2017
@jctanner jctanner merged commit 2c81e05 into ansible:devel Feb 14, 2017
@timuster timuster deleted the netapp-ontap-module-user branch March 9, 2017 20:11
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay left review comments

Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@timuster @ansibot @hulquest @lmprice @mattclay @jctanner @s-hertel