Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of deprecated parameters in module_utils/urls.py #80490

Closed
mattclay opened this issue Apr 12, 2023 · 3 comments · Fixed by #80751
Closed

Fix use of deprecated parameters in module_utils/urls.py #80490

mattclay opened this issue Apr 12, 2023 · 3 comments · Fixed by #80751
Assignees
Labels
affects_2.16 feature This issue/PR relates to a feature request. has_pr This issue has an associated PR. P2 Priority 2 - Issue Blocks Release

Comments

@mattclay
Copy link
Member

Summary

In Python 3.12 the deprecated key_file, cert_file and check_hostname parameters have been removed.

There is code which still attempts to set these, such as:

def _build_https_connection(self, host, **kwargs):
kwargs.update({
'cert_file': self.client_cert,
'key_file': self.client_key,
})

Which results in an error under Python 3.12:

>       return httplib.HTTPSConnection(host, **kwargs)
E       TypeError: HTTPSConnection.__init__() got an unexpected keyword argument 'cert_file'

Issue Type

Feature Idea

Component Name

module_utils/urls.py

@mattclay mattclay added the P2 Priority 2 - Issue Blocks Release label Apr 12, 2023
@ansibot
Copy link
Contributor

ansibot commented Apr 12, 2023

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added affects_2.16 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. labels Apr 12, 2023
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Apr 12, 2023
@Krishhhnaa
Copy link

Krishhhnaa commented Apr 12, 2023

Please assign this issue to me

@mattclay
Copy link
Member Author

@Krishhhnaa Thank you for your interest in contributing to the Ansible project. This issue was created primarily for the Ansible Core Team's own tracking, and one of our team members will be working on it. If you haven't already, I recommend taking a look at our contributor documentation to help identify areas where you can help.

@jborean93 jborean93 self-assigned this Apr 25, 2023
@ansibot ansibot added the has_pr This issue has an associated PR. label May 10, 2023
@ansible ansible locked and limited conversation to collaborators May 24, 2023
@sivel sivel moved this to Done in ansible-core 2.16 Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.16 feature This issue/PR relates to a feature request. has_pr This issue has an associated PR. P2 Priority 2 - Issue Blocks Release
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants