Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zabbix.zabbix_agent: zabbix_agent_tlsaccept, zabbix_agent_tlsconnect #1338

Closed
ezekieldas opened this issue Jul 10, 2024 · 0 comments · Fixed by #1343
Closed

zabbix.zabbix_agent: zabbix_agent_tlsaccept, zabbix_agent_tlsconnect #1338

ezekieldas opened this issue Jul 10, 2024 · 0 comments · Fixed by #1343
Labels
enhancement New feature or request role The issue or pull request is related to Zabbix role

Comments

@ezekieldas
Copy link

SUMMARY

My configuration uses multiple values for TLSAccept=psk,cert The current template disallows this, looks incorrect, and results in the agent failing on start.

https://github.com/ansible-collections/community.zabbix/blob/main/roles/zabbix_agent/templates/agent.conf.j2#L124

{{ (zabbix_agent_tlsconnect is defined and zabbix_agent_tlsconnect is not none) | ternary('', '# ') }}TLSAccept={{ zabbix_agent_tlsconnect | default('') }}

should be:

{{ (zabbix_agent_tlsconnect is defined and zabbix_agent_tlsconnect is not none) | ternary('', '# ') }}TLSConnect={{ zabbix_agent_tlsconnect | default('') }}
{{ (zabbix_agent_tlsaccept is defined and zabbix_agent_tlsaccept is not none) | ternary('', '# ') }}TLSAccept={{ zabbix_agent_tlsaccept | default('') }}
ISSUE TYPE
  • Bug Report
COMPONENT NAME
ANSIBLE VERSION
ansible 2.10.8
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.10.12 (main, Mar 22 2024, 16:50:05) [GCC 11.4.0]
CONFIGURATION
ANSIBLE_PIPELINING(/etc/ansible/ansible.cfg) = True
DEFAULT_ROLES_PATH(/etc/ansible/ansible.cfg) = ['/etc/ansible/roles']
DEFAULT_VAULT_PASSWORD_FILE(/etc/ansible/ansible.cfg) = /etc/ansible_vault
HOST_KEY_CHECKING(/etc/ansible/ansible.cfg) = False
OS / ENVIRONMENT / Zabbix Version

Zabbix Agent 2 (6.4.16)

STEPS TO REPRODUCE

Use role community.zabbix.zabbix_agent with variable zabbix_agent_tlsaccept: "psk,cert"

EXPECTED RESULTS

TLSAccept=psk,cert

ACTUAL RESULTS

TLSAccept=psk


@pyrodie18 pyrodie18 added enhancement New feature or request role The issue or pull request is related to Zabbix role labels Jul 13, 2024
@BGmot BGmot mentioned this issue Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request role The issue or pull request is related to Zabbix role
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants