Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache2-mod-proxy: receive results from fetch_url as tuple of vars #9608

Merged
merged 2 commits into from
Jan 23, 2025
Merged

apache2-mod-proxy: receive results from fetch_url as tuple of vars #9608

merged 2 commits into from
Jan 23, 2025

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jan 22, 2025

SUMMARY

Improve readability of code by receiving the result of fetch_url as a tuple of variables instead of a single variable that is used with indexes later.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

apache2_mod_proxy

@ansibullbot
Copy link
Collaborator

cc @oboukili
click here for bot help

@ansibullbot ansibullbot added module module plugins plugin (any type) labels Jan 22, 2025
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Jan 22, 2025
@felixfontein felixfontein merged commit d7f067d into ansible-collections:main Jan 23, 2025
138 checks passed
@patchback Patchback
Copy link

patchback bot commented Jan 23, 2025 •
edited
Loading

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/d7f067dd2842edea1bb2ae3e17d11ee67d9635dd/pr-9608

Backported as #9610

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 23, 2025
patchback bot pushed a commit that referenced this pull request Jan 23, 2025
@russoz @patchback
apache2-mod-proxy: receive results from fetch_url as tuple of vars (#…
0d4937c 
…9608)

* apache2-mod-proxy: receive results from fetch_url as tuple of vars

* add changelog frag

(cherry picked from commit d7f067d)
@patchback patchback bot mentioned this pull request Jan 23, 2025
Merged
@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!

@russoz russoz deleted the apache2-mod-proxy-revamp-3 branch January 23, 2025 05:51
felixfontein pushed a commit that referenced this pull request Jan 23, 2025
@patchback @russoz
[PR #9608/d7f067dd backport][stable-10] apache2-mod-proxy: receive re…
769b22c 
…sults from fetch_url as tuple of vars (#9610)

apache2-mod-proxy: receive results from fetch_url as tuple of vars (#9608)

* apache2-mod-proxy: receive results from fetch_url as tuple of vars

* add changelog frag

(cherry picked from commit d7f067d)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
@russoz @Massl123
apache2-mod-proxy: receive results from fetch_url as tuple of vars (a…
3dd5d5a 
…nsible-collections#9608)

* apache2-mod-proxy: receive results from fetch_url as tuple of vars

* add changelog frag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-10 Automatically create a backport for the stable-10 branch module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein