Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module helper: delegate debug() to AnsibleModule #9577

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jan 16, 2025

SUMMARY

Add delegation of method debug() to self.module. If the attribute already exists, issues a warning instead, asking for the developer to rename it un the release of c.g. 12.0.0.

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

docs/docsite/rst/guide_modulehelper.rst
plugins/module_utils/mh/base.py

@ansibullbot ansibullbot added docs module_utils module_utils plugins plugin (any type) labels Jan 16, 2025
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Jan 18, 2025
@russoz russoz force-pushed the mh-delegate-debug branch from 0f77e7a to 115e6f7 Compare January 20, 2025 00:24
@felixfontein felixfontein merged commit 7fa859a into ansible-collections:main Jan 20, 2025
138 checks passed
Copy link

patchback bot commented Jan 20, 2025

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/7fa859a3b893f58a791bc39083907b14ac0157c3/pr-9577

Backported as #9591

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 20, 2025
patchback bot pushed a commit that referenced this pull request Jan 20, 2025
* module helper: delegate debug() to AnsibleModule

* add changelog frag

* add comments for future

* use deprecate()

* fix errors

(cherry picked from commit 7fa859a)
@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!

@russoz russoz deleted the mh-delegate-debug branch January 20, 2025 18:52
felixfontein pushed a commit that referenced this pull request Jan 20, 2025
…() to AnsibleModule (#9591)

module helper: delegate debug() to AnsibleModule (#9577)

* module helper: delegate debug() to AnsibleModule

* add changelog frag

* add comments for future

* use deprecate()

* fix errors

(cherry picked from commit 7fa859a)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
…#9577)

* module helper: delegate debug() to AnsibleModule

* add changelog frag

* add comments for future

* use deprecate()

* fix errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-10 Automatically create a backport for the stable-10 branch docs module_utils module_utils plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants