Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defghi*: style adjustments #9532

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jan 6, 2025

SUMMARY

Second round of doc adjustments. Output width has been slightly reduced in andebox, and a couple of other style improvements have been added (like replacing id with ID)

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/modules/dconf.py
plugins/modules/dimensiondata_vlan.py
plugins/modules/dnsimple.py
plugins/modules/dnsmadeeasy.py
plugins/modules/dpkg_divert.py
plugins/modules/emc_vnx_sg_member.py
plugins/modules/flatpak.py
plugins/modules/gconftool2.py
plugins/modules/gitlab_deploy_key.py
plugins/modules/gitlab_group.py
plugins/modules/gitlab_hook.py
plugins/modules/gitlab_project.py
plugins/modules/gitlab_user.py
plugins/modules/gunicorn.py
plugins/modules/hg.py
plugins/modules/hipchat.py
plugins/modules/honeybadger_deployment.py
plugins/modules/hpilo_boot.py
plugins/modules/hwc_network_vpc.py
plugins/modules/ibm_sa_domain.py
plugins/modules/icinga2_host.py
plugins/modules/imc_rest.py
plugins/modules/infinity.py
plugins/modules/influxdb_retention_policy.py
plugins/modules/ipa_otptoken.py
plugins/modules/ipmi_boot.py
plugins/modules/ipmi_power.py

@ansibullbot ansibullbot added docs module module plugins plugin (any type) labels Jan 6, 2025
@felixfontein felixfontein added callback callback plugin check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch and removed callback callback plugin labels Jan 6, 2025
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein merged commit 8cef0ee into ansible-collections:main Jan 7, 2025
129 checks passed
Copy link

patchback bot commented Jan 7, 2025

Backport to stable-9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 8cef0ee on top of patchback/backports/stable-9/8cef0ee551bf12eb2057a80495b36fef9ebdce8b/pr-9532

Backporting merged PR #9532 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-9/8cef0ee551bf12eb2057a80495b36fef9ebdce8b/pr-9532 upstream/stable-9
  4. Now, cherry-pick PR defghi*: style adjustments #9532 contents into that branch:
    $ git cherry-pick -x 8cef0ee551bf12eb2057a80495b36fef9ebdce8b
    If it'll yell at you with something like fatal: Commit 8cef0ee551bf12eb2057a80495b36fef9ebdce8b is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 8cef0ee551bf12eb2057a80495b36fef9ebdce8b
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR defghi*: style adjustments #9532 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-9/8cef0ee551bf12eb2057a80495b36fef9ebdce8b/pr-9532
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 7, 2025
Copy link

patchback bot commented Jan 7, 2025

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/8cef0ee551bf12eb2057a80495b36fef9ebdce8b/pr-9532

Backported as #9544

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks again!

patchback bot pushed a commit that referenced this pull request Jan 7, 2025
* defghi*: style adjustments

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8cef0ee)
felixfontein pushed a commit that referenced this pull request Jan 7, 2025
…9544)

defghi*: style adjustments (#9532)

* defghi*: style adjustments

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8cef0ee)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the defghi-doc-style branch January 7, 2025 08:11
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
* defghi*: style adjustments

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch docs module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants