Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache2_mod_proxy: big revamp #9457

Merged
merged 3 commits into from
Feb 26, 2025
Merged

apache2_mod_proxy: big revamp #9457

merged 3 commits into from
Feb 26, 2025

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Dec 29, 2024

SUMMARY

Simplified the module, but keeping the exact same logic

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

apache2_mod_proxy

@ansibullbot
Copy link
Collaborator

cc @oboukili
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress module module plugins plugin (any type) labels Dec 29, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Dec 29, 2024
@russoz russoz changed the title [WIP] apache2_mod_proxy: big revamp apache2_mod_proxy: big revamp Dec 30, 2024
@ansibullbot ansibullbot removed the WIP Work in progress label Dec 30, 2024
@russoz russoz requested a review from felixfontein January 1, 2025 08:27
felixfontein
felixfontein reviewed Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How intensively did you test this module? There are unfortunately no tests for this module around...

@russoz
Copy link
Collaborator Author

russoz commented Jan 4, 2025

How intensively did you test this module? There are unfortunately no tests for this module around...

I did not test it. The logic is relatively simple and it was maintained to the best of my ability.

@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 6, 2025
@russoz russoz force-pushed the apache2-mod-proxy-revamp branch from 8655d8c to 67cafa8 Compare January 10, 2025 09:39
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jan 18, 2025
@russoz russoz force-pushed the apache2-mod-proxy-revamp branch from 67cafa8 to c00405d Compare January 22, 2025 22:08
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Jan 22, 2025
@russoz russoz force-pushed the apache2-mod-proxy-revamp branch 2 times, most recently from 6124e55 to c25e6b1 Compare January 23, 2025 10:05
@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 23, 2025
@russoz russoz force-pushed the apache2-mod-proxy-revamp branch from c25e6b1 to 19d1106 Compare January 24, 2025 02:16
@ansibullbot ansibullbot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 24, 2025
@russoz russoz mentioned this pull request Jan 25, 2025
Merged
@russoz russoz force-pushed the apache2-mod-proxy-revamp branch from 4f210c9 to 31af30c Compare January 26, 2025 21:03
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 26, 2025
@russoz russoz requested a review from felixfontein January 26, 2025 22:04
@russoz
Copy link
Collaborator Author

russoz commented Feb 1, 2025

hi @felixfontein I suppose you won't have a lot of time in the next few days, but whenever you can, please take a look at this one ;-) TIA

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Feb 9, 2025
@felixfontein
Copy link
Collaborator

My first tries to test this basically didn't work because the module is Python 2 only. Its sole requirement - BeautifulSoup - only runs on Python 2. Upgrading to BeautifulSoup 4 and adjusting the import results in TypeError: cannot use a string pattern on a bytes-like object, since the module likely never was adjusted to work with Python 3 (due to the library it needs not being available there).

While looking for that, I found #4167 and #7455. I'm currently working on getting the module running on Python 3 with bs4, and adding basic tests.

@felixfontein felixfontein mentioned this pull request Feb 16, 2025
Merged
@felixfontein
Copy link
Collaborator

#9762 fixes the module to make it work with Python 3 and half-way modern Apache 2 releases (basically all that still are around nowadays, I'd guess). Sorry for getting you to rebase this again, but at least with that PR the module will be known to work due to having tests ;-)

@patchback patchback bot mentioned this pull request Feb 18, 2025
Merged
@russoz russoz force-pushed the apache2-mod-proxy-revamp branch from 26d0b11 to 6ac825e Compare February 24, 2025 06:57
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Feb 24, 2025
@russoz
Copy link
Collaborator Author

russoz commented Feb 24, 2025

hi @felixfontein , local tests failed miserably - I do recall you mentioning going through hoops to get it to work. Could you please wirte a README.md for this test target explaining what is needed? Otherwise that knowledge is likely to fade away from your memory over time. TIA

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Feb 24, 2025
@felixfontein
Copy link
Collaborator

@russoz the tests should "just run" with any of the platforms that run in CI. Something like ansible-test integration --docker ubuntu2404 -v apache2_mod_proxy should just work. The problem was getting the tests to run, not actually running the tests once they were working :)

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Feb 25, 2025
@felixfontein felixfontein merged commit 98b328c into ansible-collections:main Feb 26, 2025
138 checks passed
@patchback Patchback
Copy link

patchback bot commented Feb 26, 2025 •
edited
Loading

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/98b328c5392632f5e35d84a5a4eb77a6e33ef4dd/pr-9457

Backported as #9806

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Feb 26, 2025
patchback bot pushed a commit that referenced this pull request Feb 26, 2025
@russoz @patchback
apache2_mod_proxy: big revamp (#9457)
8fe0813 
* apache2_mod_proxy: big revamp

* fix case when state=null

* fix logic for change detection

(cherry picked from commit 98b328c)
@patchback patchback bot mentioned this pull request Feb 26, 2025
Merged
@felixfontein
Copy link
Collaborator

@russoz thanks!

felixfontein pushed a commit that referenced this pull request Feb 26, 2025
@patchback @russoz
[PR #9457/98b328c5 backport][stable-10] apache2_mod_proxy: big revamp (…
7d8f555 
…#9806)

apache2_mod_proxy: big revamp (#9457)

* apache2_mod_proxy: big revamp

* fix case when state=null

* fix logic for change detection

(cherry picked from commit 98b328c)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the apache2-mod-proxy-revamp branch February 27, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-10 Automatically create a backport for the stable-10 branch module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein