From 981ca2558b175f64a8fd1fc76e237aa2bdd2984a Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Sun, 21 Mar 2021 15:28:18 +0100 Subject: [PATCH 1/2] Enable the SNS Topic tests --- tests/integration/targets/sns_topic/aliases | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/integration/targets/sns_topic/aliases b/tests/integration/targets/sns_topic/aliases index e4280272565..a112c3d1bb2 100644 --- a/tests/integration/targets/sns_topic/aliases +++ b/tests/integration/targets/sns_topic/aliases @@ -1,4 +1,2 @@ -# reason: missing-policy -unsupported - cloud/aws +shippable/aws/group1 From e9e29ef0544201ad2d18d30d8211fbc7eee0758b Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Fri, 21 May 2021 21:01:15 +0200 Subject: [PATCH 2/2] Use shorter names --- tests/integration/targets/sns_topic/defaults/main.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/integration/targets/sns_topic/defaults/main.yml b/tests/integration/targets/sns_topic/defaults/main.yml index 4082236c73b..7fd3a2f50ef 100644 --- a/tests/integration/targets/sns_topic/defaults/main.yml +++ b/tests/integration/targets/sns_topic/defaults/main.yml @@ -1,15 +1,16 @@ -sns_topic_topic_name: "{{ resource_prefix }}-topic" +unique_id: "{{ resource_prefix | md5sum }}" + +sns_topic_topic_name: "ansible-test-{{ unique_id }}-topic" sns_topic_subscriptions: - endpoint: "{{ sns_topic_subscriber_arn }}" protocol: "lambda" sns_topic_third_party_topic_arn: "arn:aws:sns:us-east-1:806199016981:AmazonIpSpaceChanged" sns_topic_third_party_region: "{{ sns_topic_third_party_topic_arn.split(':')[3] }}" sns_topic_lambda_function: "sns_topic_lambda" -sns_topic_lambda_name: "{{ resource_prefix }}-{{ sns_topic_lambda_function }}" +sns_topic_lambda_name: "ansible-test-{{ unique_id }}-{{ sns_topic_lambda_function }}" # IAM role names have to be less than 64 characters # The 8 digit identifier at the end of resource_prefix helps determine during # which test something was created and allows tests to be run in parallel # Shippable resource_prefixes are in the format shippable-123456-123, so in those cases # we need both sets of digits to keep the resource name unique -unique_id: "{{ resource_prefix | regex_search('(\\d+-?)(\\d+)$') }}" sns_topic_lambda_role: "ansible-test-{{ unique_id }}-sns-lambda"