From b40e48d00919418153dc9895feb105cb36984892 Mon Sep 17 00:00:00 2001 From: Markus Bergholz Date: Thu, 11 Feb 2021 19:11:32 +0100 Subject: [PATCH 1/2] #404 fix wrong element spec for rules param --- .../404-fix-dict-element-for-rule-param-in-aws-s3-cors.yml | 2 ++ plugins/modules/aws_s3_cors.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/404-fix-dict-element-for-rule-param-in-aws-s3-cors.yml diff --git a/changelogs/fragments/404-fix-dict-element-for-rule-param-in-aws-s3-cors.yml b/changelogs/fragments/404-fix-dict-element-for-rule-param-in-aws-s3-cors.yml new file mode 100644 index 00000000000..e6eb68bbabd --- /dev/null +++ b/changelogs/fragments/404-fix-dict-element-for-rule-param-in-aws-s3-cors.yml @@ -0,0 +1,2 @@ +bugfixes: +- aws_s3_cors - fix element type for rules parameter. (https://github.com/ansible-collections/community.aws/pull/408). diff --git a/plugins/modules/aws_s3_cors.py b/plugins/modules/aws_s3_cors.py index 820530dc08d..f87de588d69 100644 --- a/plugins/modules/aws_s3_cors.py +++ b/plugins/modules/aws_s3_cors.py @@ -147,7 +147,7 @@ def main(): argument_spec = dict( name=dict(required=True, type='str'), - rules=dict(type='list', elements='str'), + rules=dict(type='list', elements='dict'), state=dict(type='str', choices=['present', 'absent'], required=True) ) From b73f0a84fbe2dd7eccae38c22019b4dd153781f8 Mon Sep 17 00:00:00 2001 From: Markus Bergholz Date: Thu, 11 Feb 2021 19:34:23 +0100 Subject: [PATCH 2/2] #404 documentation fix --- plugins/modules/aws_s3_cors.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/aws_s3_cors.py b/plugins/modules/aws_s3_cors.py index f87de588d69..58e33cf1104 100644 --- a/plugins/modules/aws_s3_cors.py +++ b/plugins/modules/aws_s3_cors.py @@ -25,7 +25,7 @@ description: - Cors rules to put on the s3 bucket type: list - elements: str + elements: dict state: description: - Create or remove cors on the s3 bucket