ec2_asg module does not check instance health status

[ehorning]

SUMMARY

Due to the ASG grace period, it appears it is possible for an EC2 to report a lifecycle state of "InService" on the ASG while still reporting an instance status of "Unhealthy" on the ASG. The ec2_asg module proceeds successfully in this scenario even though registering and debugging the result shows the following:

       "instance_facts": {
          "xxx": {
                "health_status": "Unhealthy",
                "launch_config_name": "yyy",
                 "lifecycle_state": "InService"
             }
         }

I believe this is due to the fact that there is no check of the health status here

ISSUE TYPE

• Bug Report

COMPONENT NAME

ec2_asg

ANSIBLE VERSION

2.7.10

OS / ENVIRONMENT

Xenial EC2

STEPS TO REPRODUCE

Deploy a broken AMI via an autoscaling group using the ec2_asg module, a classic load balancer, and ELB health checks on the ASG

EXPECTED RESULTS

The module should wait until the instance is healthy and fail if the instance does not become healthy before the timeout

ACTUAL RESULTS

The module waited for the instance to enter lifecycle state "InService" and then proceeded with the deploy despite the fact that the instance health status was still "Unhealthy"

[ansibullbot]

Files identified in the description:

• plugins/modules/ec2_asg.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @garethr @jillr @s-hertel @tremble @wimnat
click here for bot help

[mandar242]

Hi @ehorning , Thank you for contributing!
Could you please test if the issue persists/is reproducible with the latest version of Ansible and community.aws collection?

[ansibullbot]

cc @markuman
click here for bot help

[jillr]

Ansible Engine 2.7 reached end of support on June 18, 2020. As we have not been able to confirm that the problem persists in recent, supported versions of Ansible Engine or the community.aws collection and the scenario depends on a broken EC2 configuration we will close this ticket. If a reproducer using currently supported versions of the software can be provided please let us know. Thank you for your interest in Ansible!