From 879b28bfee24b5855c27dfc11775d9f0dadacc36 Mon Sep 17 00:00:00 2001 From: Fred-sun Date: Thu, 15 Oct 2020 15:19:03 +0800 Subject: [PATCH 1/3] add new --- plugins/modules/azure_rm_roleassignment.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/modules/azure_rm_roleassignment.py b/plugins/modules/azure_rm_roleassignment.py index 24cb5ff2d..25f09abb9 100644 --- a/plugins/modules/azure_rm_roleassignment.py +++ b/plugins/modules/azure_rm_roleassignment.py @@ -25,6 +25,8 @@ name: description: - Unique name of role assignment. + - The role assignment name must be a GUID. + require: true assignee_object_id: description: - The object id of assignee. This maps to the ID inside the Active Directory. @@ -114,7 +116,8 @@ class AzureRMRoleAssignment(AzureRMModuleBase): def __init__(self): self.module_arg_spec = dict( name=dict( - type='str' + type='str', + require='true' ), scope=dict( type='str' @@ -167,9 +170,6 @@ def exec_module(self, **kwargs): # build cope self.scope = self.build_scope() - if self.name is None: - self.name = str(uuid.uuid4()) - # get existing role assignment old_response = self.get_roleassignment() From 5e601232e5fb2dc2ca07b8cdeeb37cf9238d11bd Mon Sep 17 00:00:00 2001 From: Fred-sun Date: Thu, 15 Oct 2020 15:23:55 +0800 Subject: [PATCH 2/3] add sample --- plugins/modules/azure_rm_roleassignment.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/azure_rm_roleassignment.py b/plugins/modules/azure_rm_roleassignment.py index 25f09abb9..cdcdb2a13 100644 --- a/plugins/modules/azure_rm_roleassignment.py +++ b/plugins/modules/azure_rm_roleassignment.py @@ -25,7 +25,7 @@ name: description: - Unique name of role assignment. - - The role assignment name must be a GUID. + - The role assignment name must be a GUID, sample as "3ce0cbb0-58c4-4e6d-a16d-99d86a78b3ca". require: true assignee_object_id: description: From 383c77015504f6c28c478a429e656e366591ab2a Mon Sep 17 00:00:00 2001 From: Fred-sun Date: Thu, 15 Oct 2020 15:44:00 +0800 Subject: [PATCH 3/3] update new --- plugins/modules/azure_rm_roleassignment.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/modules/azure_rm_roleassignment.py b/plugins/modules/azure_rm_roleassignment.py index cdcdb2a13..b33ebb622 100644 --- a/plugins/modules/azure_rm_roleassignment.py +++ b/plugins/modules/azure_rm_roleassignment.py @@ -26,7 +26,7 @@ description: - Unique name of role assignment. - The role assignment name must be a GUID, sample as "3ce0cbb0-58c4-4e6d-a16d-99d86a78b3ca". - require: true + required: True assignee_object_id: description: - The object id of assignee. This maps to the ID inside the Active Directory. @@ -84,8 +84,6 @@ sample: "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/Microsoft.Authorization/roleAssignments/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" ''' -import uuid - try: from ansible_collections.azure.azcollection.plugins.module_utils.azure_rm_common import AzureRMModuleBase from msrestazure.azure_exceptions import CloudError @@ -117,7 +115,7 @@ def __init__(self): self.module_arg_spec = dict( name=dict( type='str', - require='true' + required=True ), scope=dict( type='str'