Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release branch wildcard .* broken #178

Closed
aarontwf opened this issue Sep 12, 2022 · 5 comments
Closed

Release branch wildcard .* broken #178

aarontwf opened this issue Sep 12, 2022 · 5 comments
Assignees
@sbe-arg
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@aarontwf
Copy link

aarontwf commented Sep 12, 2022 •
edited
Loading

Seems like the action no longer respects wildcards in recent versions. Could be related to this change e4d41c4.

Before (1.39.0)

*** CONFIGURATION ***
	DEFAULT_BUMP: patch
	WITH_V: true
	RELEASE_BRANCHES: .*
	CUSTOM_TAG: 
	SOURCE: .
	DRY_RUN: true
	INITIAL_VERSION: 0.0.0
	TAG_CONTEXT: repo
	PRERELEASE_SUFFIX: beta
	VERBOSE: false
Is .* a match for HEAD
pre_release = false
patch
Bumping tag v1.56.0. 
	New tag v1.56.1

With 1.40.0

*** CONFIGURATION ***
	DEFAULT_BUMP: patch
	WITH_V: true
	RELEASE_BRANCHES: .*
	CUSTOM_TAG: 
	SOURCE: .
	DRY_RUN: true
	INITIAL_VERSION: 0.0.0
	TAG_CONTEXT: repo
	PRERELEASE_SUFFIX: beta
	VERBOSE: false
pre_release = true
Setting beta pre-tag . With pre-tag v1.56.2-beta.0
@sammcj sammcj added bug Something isn't working help wanted Extra attention is needed labels Sep 13, 2022
@Fuerback
Copy link

The change which causes it seems to be this one 1.39.0...1.40.0#diff-6f9d41d046756f0ddc2fcee0626bdb50100d12b88f293734eff742818e03efa2L40

@sbe-arg sbe-arg self-assigned this Sep 27, 2022
@sbe-arg
Copy link
Collaborator

sbe-arg commented Sep 27, 2022

Gonna work on this this week.

@sbe-arg
Copy link
Collaborator

sbe-arg commented Sep 27, 2022

@Fuerback #190

@sbe-arg
Copy link
Collaborator

sbe-arg commented Sep 28, 2022 •
edited
Loading

@Fuerback please test the latest version 1.49.0 and report back, will close in the meantime

@sbe-arg sbe-arg closed this as completed Sep 28, 2022
@Fuerback
Copy link

Fuerback commented Oct 3, 2022

Thanks @sbe-arg, using 1.51.0 and it's working just fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbe-arg sbe-arg

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sammcj @aarontwf @Fuerback @sbe-arg