Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#major and #patch not working #165

Closed
can-I-do opened this issue Jul 29, 2022 · 6 comments
Closed

#major and #patch not working #165

can-I-do opened this issue Jul 29, 2022 · 6 comments

Comments

@can-I-do
Copy link

Hey everyone,

maybe I misunderstood something, but for us the tagging via keywords in the commit message is not working. It always does the default (minor) increment of the patch.

Another thing is, if you already have a tag like v1.0 it is not creating the initial tag, instead it is creating a v. without numbers.

CleanShot 2022-07-29 at 08 54 18

@DeepCowProductions
Copy link

DeepCowProductions commented Aug 17, 2022

Same here. It also appears to just completely ignore #minor #major #patch in the commit messages.

Edit: The Issue seems to be log=$(git log $tag..HEAD --pretty='%B'). Semver command, makes 'v' disappear.

@zozoxo1
Copy link

zozoxo1 commented Aug 17, 2022

https://github.com/fhswf/JupyterHub-Autotagger-Action/tree/v1.0.3 we fixed this issue by checking if the with_v variable is set. You can use our release if you want.

@pacroy
Copy link

pacroy commented Aug 25, 2022

As workaround, I switched back to 1.36.0 as these tags are still working fine.

@sbe-arg
Copy link
Collaborator

sbe-arg commented Sep 7, 2022

#157
test using sbe-arg/github-tag-action@1.39.6

@sammcj
Copy link
Collaborator

sammcj commented Sep 13, 2022

This should be resolved now, if not let me know and I'll reopen.

@sammcj sammcj closed this as completed Sep 13, 2022
@dgokcin
Copy link

dgokcin commented Oct 18, 2022

@sammcj I think the issue is still present. I created a new issue in #207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants