Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output tag without 'v' prefix #116

Closed
skst opened this issue May 15, 2021 · 6 comments
Closed

Output tag without 'v' prefix #116

skst opened this issue May 15, 2021 · 6 comments

Comments

@skst
Copy link

skst commented May 15, 2021

Thank you for providing this action.

I would like to use the new tag without the v for the name of my release. Unfortunately, GitHub does not provide string manipulation. I can run this action with DRY_RUN to get the tag without the v, but it would be more convenient if it were one of the outputs.

Thank you for considering this enhancement.

@anothrNick
Copy link
Owner

@skst WITH_V is an optional environment variable that is set to true in the example config in the README. If you remove this or set it to false the tag will be generated without the prefix.

I primarily use this action without any prefix.

@skst
Copy link
Author

skst commented May 18, 2021

Absolutely, and I like that it's optional. After I use github-tag-action to tag the branch, I use create-release to create a release and attach an artifact. I want to name the release with the version but without the v prefix. Currently, I have to run github-tag-action with DRY_RUN set to true to get the tag without the v prefix. It would be more convenient if both the tag with prefix and without were outputs of the actual run.

@anothrNick
Copy link
Owner

Ah I see, so you want the tag to exist in Github with the prefix, but want to include it in the name of the release without the prefix.

Although the tag output on Dryrun is the old tag

https://github.com/anothrNick/github-tag-action/blob/master/entrypoint.sh#L144

Regardless, we could set another output here: https://github.com/anothrNick/github-tag-action/blob/master/entrypoint.sh#L115
Which would be without the v prefix.

@skst
Copy link
Author

skst commented May 18, 2021

Ah I see, so you want the tag to exist in Github with the prefix, but want to include it in the name of the release without the prefix.

Exactly.

Although the tag output on Dryrun is the old tag

Hmm. It seems to be outputting the new tag for me. It's working great.

image

Regardless, we could set another output here ... Which would be without the v prefix.

That would be awesome. 👍

@sbe-arg
Copy link
Collaborator

sbe-arg commented May 17, 2022

#157

@sbe-arg
Copy link
Collaborator

sbe-arg commented Sep 27, 2022

This has been resolved closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants