You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The shared namada crate is used by code that is compiled to wasm and also by code that is compiled to native binaries (e.g. namadac, namadan). Sometimes, things get pulled in to wasm builds via this shared crate that cause breakages. The ferveo-tpke feature is sometimes (ab)used to guard code which should only be used in native builds because it would otherwise break wasm builds e.g.
"ferveo-tpke" should only be used to guard code that is actually relevant to Ferveo functionality
we could introduce a new dedicated feature for guarding code that shouldn't ever be included in wasm builds and use that instead of "ferveo-tpke". Even if this is only an interim solution until wasm-breaking functionality could be split out from the namada crate altogether.
The text was updated successfully, but these errors were encountered:
james-chf
changed the title
Remove "ferveo-tpke" feature guards that are only being used to prevent wasm build breakages
Replace "ferveo-tpke" feature guards that are only being used to prevent wasm build breakages
Nov 17, 2022
The shared
namada
crate is used by code that is compiled to wasm and also by code that is compiled to native binaries (e.g.namadac
,namadan
). Sometimes, things get pulled in to wasm builds via this shared crate that cause breakages. Theferveo-tpke
feature is sometimes (ab)used to guard code which should only be used in native builds because it would otherwise break wasm builds e.g.namada/shared/src/lib.rs
Lines 9 to 12 in 2604a91
namada
crate altogether.The text was updated successfully, but these errors were encountered: